LineBreaker.cpp: converting integer literal to bool, use bool literal instead
Categories
(Developer Infrastructure :: Source Code Analysis, task)
Tracking
(firefox77 fixed)
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: mhd.tahawi, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1629431 +++
Filling as a good first bug to learn workflows.
Replace 1 by true (it is casted to bool anyway)
https://searchfox.org/mozilla-central/source/intl/lwbrk/LineBreaker.cpp#793
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/modernize-use-bool-literals.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
Also, please only work on two max of such bugs.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
Reporter | |
Comment 2•5 years ago
|
||
Comment on attachment 9140366 [details]
Bug 1629435 - Using bool literals instead of integer literals.
we use phabricator for review. Please set the review in phab!
thanks
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
My bad, done!
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
|
||
Updated•3 years ago
|
Description
•